COS: Add http_config for cos object store client #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjm
changed the title
hanjm
changed the title
hanjm
changed the title
hanjm
force-pushed
the
feature/optimize-cos-object-transport
branch
from
2a05db2
to
f63c1c4
Compare
…s-io#4479) The http.Transport is not auto-tuning and one size does not seem to fit all cases. Add `HTTPConfig` Allow to tune most of the http.Transport parameters and `MaxIdleConnsPerHost` tune to 100. Signed-off-by: hanjm <[email protected]>
Signed-off-by: hanjm <[email protected]>
Signed-off-by: hanjm <[email protected]>
hanjm
force-pushed
the
feature/optimize-cos-object-transport
branch
3 times, most recently
from
e1b8520
to
49d1ca9
Compare
Signed-off-by: hanjm <[email protected]>
hanjm
force-pushed
the
feature/optimize-cos-object-transport
branch
from
49d1ca9
to
cca6bf3
Compare
|
Hi @ jojohappy，could you help me review this PR if convenient，thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4479
The http.Transport is not auto-tuning and one size does not seem to fit all cases.
Add
HTTPConfigAllow to tune most of the http.Transport parameters andMaxIdleConnsPerHosttune to 100.Signed-off-by: hanjm [email protected]
Changes
add http_config for cos storage.
Verification
unit test .
redeploy thanos tools bucket web, no TIME_WAIT connection.