ui: Add search block UI #4444
Merged
ui: Add search block UI #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jul 14, 2021
onprem
reviewed
Jul 28, 2021
squat
reviewed
Aug 4, 2021
| const resultIndex = result.map((value) => value.index); | ||
|
|
||
| const blockResult = blocks.filter((block, index) => resultIndex.includes(index)); | ||
| return blockResult; |
There was a problem hiding this comment.
I spoke with @adzshaf and mentioned that I think this could produce confusing experience for the user. If I provide full-length ULID that matches a block name exactly, but fuzzy search returns more than one result, then I would be very confused and asume that all of the blocks have the same name, which should not really be happening. I think it's fair to return multiple blocks if the ULID does not match any block exactly, i.e. it is not full-length or has a typo.
We can do this in a follow up of course, since this UI already provides a ton of value.
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
adzshaf
force-pushed
the
add-search-block-ui
branch
from
4d48fb8
to
e05ed00
Compare
squat
previously approved these changes
Aug 4, 2021
|
actually! this PR should definitely have a changelog entry! It provides a great new feature for the user |
Signed-off-by: Shafiya Adzhani <[email protected]>
adzshaf
force-pushed
the
add-search-block-ui
branch
from
22b2e51
to
3ede8bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is part of LFX Mentorship project (issue: #3112). We want to add Search Block by ID.
Verification
When we haven't search anything yet:
Example search block by ID:
Tested on local using
make quickstart