Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting and filtering to flags page #4403

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Add sorting and filtering to flags page #4403

merged 3 commits into from
Jul 2, 2021

Conversation

Nexucis
Copy link
Contributor

@Nexucis Nexucis commented Jul 2, 2021

fix #4400

@Nexucis
Copy link
Contributor Author

Nexucis commented Jul 2, 2021

If I'm not wrong, the review is more on your side @onprem right ? :)

onprem
onprem previously approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit in the CHANGELOG, the code looks perfect. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@yeya24
Copy link
Contributor

yeya24 commented Jul 2, 2021

@Nexucis Can you please rebase? Thanks for the contribution!

@Nexucis
add sort/filter on flags
65d02c8 
Signed-off-by: Augustin Husson <[email protected]>
@Nexucis
replace fuzzy lib by @nexucis/fuzzy
59675aa 
Signed-off-by: Augustin Husson <[email protected]>
@Nexucis
add changelog
49297a6 
Signed-off-by: Augustin Husson <[email protected]>
@Nexucis
Copy link
Contributor Author

Nexucis commented Jul 2, 2021

@yeya24 done :)

@yeya24 yeya24 enabled auto-merge (squash) July 2, 2021 17:16
@Nexucis
Copy link
Contributor Author

Nexucis commented Jul 2, 2021

@yeya24 you need to reapprove the PR if you enable the auto merge :)

@yeya24 yeya24 disabled auto-merge July 2, 2021 17:46
yeya24
yeya24 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit bc8421a into thanos-io:main Jul 2, 2021
@Nexucis Nexucis deleted the feature/flags branch July 3, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@onprem onprem onprem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sorting and filtering to flags page
3 participants
@Nexucis @yeya24 @onprem