-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sidecar: reloader: fix output config file permission #4308
Conversation
Can you point this PR to the |
Ok, gotta do some git magic to fix the diff. gimme a few. |
Fixes: 4307 Signed-off-by: Kevin Hellemun <[email protected]>
32526f5
to
a1c0ba3
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes: 4307 Signed-off-by: Kevin Hellemun <[email protected]>
* Cut v0.21.0-rc.0 Signed-off-by: Prem Saraswat <[email protected]> * Cut v0.21.0 Signed-off-by: Prem Saraswat <[email protected]> * fix: sidecar: reloader: fix output config file permission (#4308) Fixes: 4307 Signed-off-by: Kevin Hellemun <[email protected]> * Fixed CHANGELOG for 0.21.1 Signed-off-by: Prem Saraswat <[email protected]> * Cut release v0.21.1 Signed-off-by: Prem Saraswat <[email protected]> * Revert version change Signed-off-by: Prem Saraswat <[email protected]> Co-authored-by: Kevin Hellemun <[email protected]>
fixes: #4307
Changes
Revert back permission change of reloader made in #4173
Verification
Used https://github.com/users/OGKevin/packages/container/package/thanos and works as before 👌🏾