Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearify retention #4279

Merged
merged 3 commits into from
Jun 3, 2021
Merged

clearify retention #4279

merged 3 commits into from
Jun 3, 2021

Conversation

Domi-cc
Copy link
Contributor

@Domi-cc Domi-cc commented May 27, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

onprem
onprem reviewed May 27, 2021
View reviewed changes
docs/components/sidecar.md Outdated Show resolved Hide resolved
Abhishek357
Abhishek357 suggested changes May 30, 2021
View reviewed changes
Copy link
Contributor

@Abhishek357 Abhishek357 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Domi-cc can you sign off your commits :)

@Domi-cc
Copy link
Contributor Author

Domi-cc commented Jun 3, 2021

@Abhishek357 done :)

@Abhishek357
Copy link
Contributor

@Domi-cc DCO bot still not happy because 2 commits are incorrectly signed. Go to Details and follow along.

Domi-cc and others added 3 commits June 3, 2021 15:02
@Domi-cc
clearify retention
dda9933 
Signed-off-by: Dominik Hasselkuss <[email protected]>
@Domi-cc @onprem
Update docs/components/sidecar.md
adfca78 
Co-authored-by: Prem Saraswat <[email protected]>
Signed-off-by: Dominik Hasselkuss <[email protected]>
@Domi-cc
clearify readme for retention
27c8d79 
Signed-off-by: Dominik Hasselkuss <[email protected]>
onprem
onprem approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@onprem onprem merged commit f9f2d1c into thanos-io:main Jun 3, 2021
@Domi-cc Domi-cc deleted the patch-1 branch June 3, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiardvanrij wiardvanrij wiardvanrij left review comments

@Abhishek357 Abhishek357 Abhishek357 requested changes

@onprem onprem onprem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Domi-cc @Abhishek357 @wiardvanrij @onprem