Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver: Move the Flags for receiver to a separate struct #4254

Merged
merged 2 commits into from
May 20, 2021

Conversation

yashrsharma44
Copy link
Contributor

@yashrsharma44 yashrsharma44 commented May 19, 2021

Signed-off-by: Yash Sharma [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Moved all the flags for registration for the receiver to a new struct, for improving readability and reduce cognitive load.

Verification

Let's wait for the CI to turn green :)

Related Issue: #2248

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking gooood 🚀
Thanks for cleaning this up.

@kakkoyun kakkoyun changed the title Move the Flags for receiver to a separate struct receiver: Move the Flags for receiver to a separate struct May 20, 2021
@kakkoyun kakkoyun merged commit f39ac3d into thanos-io:main May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants