Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: add dark theme #4249

Merged
merged 2 commits into from
May 22, 2021
Merged

UI: add dark theme #4249

merged 2 commits into from
May 22, 2021

Conversation

Aman-Codes
Copy link
Contributor

@Aman-Codes Aman-Codes commented May 19, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added dark theme
Closes #3775

Screenshots

Homepage

darkHomepage

lightHomepage

Status page

darkStatus

lightStatus

Store page

darkStore

lightStore

Verification

cd pkg/ui/react-app/
yarn start

@Aman-Codes Aman-Codes force-pushed the feat/dark-theme branch 2 times, most recently from 17e1da1 to 895fd18 Compare May 19, 2021 07:24
bwplotka
bwplotka previously approved these changes May 19, 2021
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG we need this.

Thanks! It looks good on outside, but we need @onprem blessing here 🙈

@roidelapluie
Copy link

This pull request seems to copy/paste code from Prometheus without the attribution required by the Apache-2 License.

@Aman-Codes
Copy link
Contributor Author

This pull request seems to copy/paste code from Prometheus without the attribution required by the Apache-2 License.

@roidelapluie To maintain consistency in Thanos and Prometheus UI, I reused the Prometheus dark theme code.
I have now added the License attribution. Let me know if anything more is required.

onprem
onprem previously approved these changes May 19, 2021
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

kakkoyun
kakkoyun previously approved these changes May 20, 2021
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Noob question: Is there a way to directly import the theme from Prometheus rather than copying over the code? It'll be hard to keep it in sync?

@onprem
Copy link
Member

onprem commented May 21, 2021

Is there a way to directly import the theme from Prometheus rather than copying over the code? It'll be hard to keep it in sync?

Currently, no. We have to publish relevant bits on npm to do that.

Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
@Aman-Codes Aman-Codes dismissed stale reviews from kakkoyun and onprem via b5d37ee May 22, 2021 04:37
@Aman-Codes
Copy link
Contributor Author

I only fixed the merged conflict. The dismissed stale reviews is due to saacs/github#1157

@kakkoyun kakkoyun enabled auto-merge (squash) May 22, 2021 08:38
@kakkoyun kakkoyun merged commit 063962c into thanos-io:main May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a dark theme in UI
5 participants