UI: Enable Targets page in Querier UI

[onprem]

Signed-off-by: Prem Saraswat [email protected]

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

• Added the missing field globalUrl in proto, which was used in the UI
• Added Targets page to the Querier nav bar

Verification

The json response format of Querier API matches with the response from Prometheus API.

[yeya24]

LGTM!

[GiedriusS]

LGTM, just have one question: maybe it's time to make --target & other flags not hidden anymore? Because I think with this link in the UI we are going to inevitably get questions about what the link is for if it's nowhere to be found :s

[onprem]

maybe it's time to make --target & other flags not hidden anymore?

Oh, I was not aware that it is hidden. I also agree to make this not hidden.

[GiedriusS]

maybe it's time to make --target & other flags not hidden anymore?

Oh, I was not aware that it is hidden. I also agree to make this not hidden.

Should we unhide them in a separate PR before merging this one? :P

[squat]

maybe it's time to make --target & other flags not hidden anymore?

Oh, I was not aware that it is hidden. I also agree to make this not hidden.

Should we unhide them in a separate PR before merging this one? :P

👍

[bwplotka]

I would propose to not UNHIDE them until @hitanshu-mehta project of unificating those into single endpoint flag as planned in https://thanos.io/tip/proposals/202101_endpoint_discovery.md/ WDYT? 🤗

Otherwise LGTM!

[GiedriusS]

I would propose to not UNHIDE them until @hitanshu-mehta project of unificating those into single endpoint flag as planned in https://thanos.io/tip/proposals/202101_endpoint_discovery.md/ WDYT?

I think it would lead to lots of questions about what is that page for and why one cannot any instructions about how to use it 🤔

[onprem]

So I guess one solution is to make targets page working but leave it out from the nav bar (similar to a hidden flag, a hidden page). So, whenever we decide to make the flag non-hidden (or we move to the --endpoint flag), we can make the page non-hidden too. WDYT?

This way, if anyone wants to really use it, they can use the hidden flag to point to sidecars and go directly to <querier-url>/new/targets.

[onprem]

I have rebased this and made the Targets page hidden from Navbar (one can manually go to /new/targets though). If we want to unhide the --target flag and the Targets page, we can do that in a separate PR.

[kakkoyun]

LGTM 🚀