Mixin: Remove dependency on the rule dashboard from compact dashboard #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goober
force-pushed
the
feature/fix-compact-mixin
branch
from
fd2eeeb
to
2687c10
Compare
…mpact dashboard. Signed-off-by: Mathias Åhsberg <[email protected]>
goober
force-pushed
the
feature/fix-compact-mixin
branch
from
2687c10
to
95fbbd8
Compare
bwplotka
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will remove the dependency between the rule dashboard and the compact dashboard mixins to be able to only generate the compact dashboard without defining the rule dashboard.
Verification
The compact dashboard has been generated and imported to Grafana with and without the included change. No visible differences found.