Tools: Rewrite delete should match even if label does not exist #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
absolutely right, thanks for catching this 👍 |
squat
approved these changes
Mar 9, 2021
|
hmm, the unit tests seems not to be completely right. Can you please take a look @ahurtaud? |
Signed-off-by: Alban HURTAUD <[email protected]>
squat
approved these changes
Mar 9, 2021
|
Hum not sure we want to merge as-is:
|
Merged
|
closed in favour of #3891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3885 - The fix provided by @yeya24 was not enough as it deleted a block matching only 1 matcher when others labelkeys do not exist.
The matcher check is done on every label keys, even if value is empty.
Verification
Edited the test to "partial" match 1 matcher