Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Create new document for rate-limiting issue #3654

Closed
wants to merge 6 commits into from
Closed

WIP: Create new document for rate-limiting issue #3654

wants to merge 6 commits into from

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Dec 19, 2020 •
edited
Loading

This is a WIP PR for tackling the problem on #3525.

Status:

Right now is on a initial draft mode, not even worth to be reviewed.

todos:

  • add solution proposal .
  • add alternatives.

@MalloZup
Copy link
Contributor Author

just reading about various things. I found also good this source:
https://cloud.google.com/solutions/rate-limiting-strategies-techniques

@bwplotka
Copy link
Member

Wow I missed this. Will take a look (:

@MalloZup
Copy link
Contributor Author

@bwplotka for the moment I wouldn't take look since I will need to work on this more and change drastically. it is more a skeleton right now..

thx for help sofar anyways 💘

bwplotka
bwplotka reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! I would add one more goal.

Plus can we choose (you can propose one) a one solution and other put in Alternatives section?

Plus I would recommend pasting this through Grammarly 🤗 There some typos.

docs/proposals/202006_thanos_grpc_rate_limiting.md Outdated Show resolved Hide resolved
docs/proposals/202006_thanos_grpc_rate_limiting.md Outdated Show resolved Hide resolved
docs/proposals/202006_thanos_grpc_rate_limiting.md Outdated Show resolved Hide resolved
docs/proposals/202006_thanos_grpc_rate_limiting.md Outdated Show resolved Hide resolved
docs/proposals/202006_thanos_grpc_rate_limiting.md Outdated Show resolved Hide resolved
@MalloZup
Copy link
Contributor Author

thx @bwplotka for review 🌻 Since I have experimented a bit today , I do have much more clear vision how to go further with this and also next year implementation..
thx again for review and helps! 🌻

@MalloZup
Copy link
Contributor Author

you can read the document here.

https://github.com/MalloZup/thanos/blob/RFC-rate-limiting/docs/proposals/202006_thanos_grpc_rate_limiting.md

@MalloZup MalloZup force-pushed the RFC-rate-limiting branch 2 times, most recently from 946a200 to e5eba76 Compare January 12, 2021 19:17
@MalloZup
Update details
c443bcb 
Signed-off-by: dmaiocchi <[email protected]>
@MalloZup MalloZup mentioned this pull request Jan 14, 2021
Merged
@kakkoyun kakkoyun marked this pull request as draft February 12, 2021 10:29
@kakkoyun kakkoyun changed the title [WIP]: Create new document for rate-limiting issue WIP: Create new document for rate-limiting issue Feb 12, 2021
Base automatically changed from master to main February 26, 2021 16:30
@stale
Copy link

stale bot commented Jun 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jun 2, 2021
@stale stale bot closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MalloZup @bwplotka