s3: Respect SignatureV2 flag for all credential providers #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
support-v2-signatures
branch
2 times, most recently
from
149127c
to
a320463
Compare
simonswine
commented
Nov 23, 2020
bwplotka
approved these changes
Nov 23, 2020
simonswine
force-pushed
the
support-v2-signatures
branch
from
a320463
to
b6a2568
Compare
Thanos currently only supports V2 signatures when the credentials are statically specified in its configuration. This change supports requesting signature V2 on other credential sources. Signed-off-by: Christian Simon <[email protected]>
Signed-off-by: Christian Simon <[email protected]>
simonswine
force-pushed
the
support-v2-signatures
branch
from
b6a2568
to
f3faf74
Compare
3 tasks
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
…3496) * s3: Respect SignatureV2 flag for all credential providers Thanos currently only supports V2 signatures when the credentials are statically specified in its configuration. This change supports requesting signature V2 on other credential sources. Signed-off-by: Christian Simon <[email protected]> * Fix docs drift Signed-off-by: Christian Simon <[email protected]> Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Thanos currently only supports V2 signatures when the credentials are statically specified in its configuration. This change supports using signature V2 on other credential sources, too.
Verification
The object storage appliance is not fully compatible with S3V4 signatures and we are able to run it statically configured with V2.
As we need to roll over the used accessKey/secretKey regularly we would like to be able to configure it via the
&credentials.IAM{}chain.