-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query-frontend: make POST-request to downstream url for labels and series api endpoints #3444
Merged
bwplotka
merged 1 commit into
thanos-io:master
from
2nick:query-frontend-series-labels-api-post
Nov 16, 2020
Merged
query-frontend: make POST-request to downstream url for labels and series api endpoints #3444
bwplotka
merged 1 commit into
thanos-io:master
from
2nick:query-frontend-series-labels-api-post
Nov 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nick
force-pushed
the
query-frontend-series-labels-api-post
branch
from
November 13, 2020 21:00
7159dc3
to
dd6dee7
Compare
…ries api endpoints Signed-off-by: Alexander Tunik <[email protected]>
2nick
force-pushed
the
query-frontend-series-labels-api-post
branch
from
November 14, 2020 10:15
dd6dee7
to
49ea2ce
Compare
bwplotka
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
LGTM
yeya24
pushed a commit
to yeya24/thanos
that referenced
this pull request
Nov 20, 2020
…ries api endpoints (thanos-io#3444) Signed-off-by: Alexander Tunik <[email protected]>
2 tasks
bwplotka
pushed a commit
that referenced
this pull request
Nov 23, 2020
* query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444) Signed-off-by: Alexander Tunik <[email protected]> * remove default response cache config Signed-off-by: Ben Ye <[email protected]> * ensure order when merging multiple responses Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]>
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
…ries api endpoints (thanos-io#3444) Signed-off-by: Alexander Tunik <[email protected]> Signed-off-by: Oghenebrume50 <[email protected]>
metalmatze
pushed a commit
to metalmatze/thanos
that referenced
this pull request
Dec 9, 2020
* query-frontend: make POST-request to downstream url for labels and series api endpoints (thanos-io#3444) Signed-off-by: Alexander Tunik <[email protected]> * remove default response cache config Signed-off-by: Ben Ye <[email protected]> * ensure order when merging multiple responses Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]>
bwplotka
added a commit
that referenced
this pull request
Dec 9, 2020
* Fix query frontend regression on release v0.17.0 (#3480) * query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444) Signed-off-by: Alexander Tunik <[email protected]> * remove default response cache config Signed-off-by: Ben Ye <[email protected]> * ensure order when merging multiple responses Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]> * *: Set debug.SetPanicOnFault(true) so we can recover seg faults. (#3498) Signed-off-by: Bartlomiej Plotka <[email protected]> * Prepare v0.17.1 release (#3505) Signed-off-by: Matthias Loibl <[email protected]> * fix index out of bound bug when comparing ZLabelSets (#3520) * fix index out of bound bug when comparing ZLabelSets Signed-off-by: Ben Ye <[email protected]> * fix param parsing error message Signed-off-by: Ben Ye <[email protected]> * address comment feedbacks Signed-off-by: Ben Ye <[email protected]> * compact: do not cleanup blocks on boot (#3532) Do not cleanup blocks on boot because in some very bad cases there could be thousands of blocks ready-to-be deleted and doing that makes Thanos Compact exceed `initialDelaySeconds` on k8s. Signed-off-by: Giedrius Statkevičius <[email protected]> * Prepare v0.17.2 (#3543) Signed-off-by: Matthias Loibl <[email protected]> * Properly rebase CHANGELOG.md after merging release-0.17 Signed-off-by: Matthias Loibl <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Alexander Tunik <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also probably fixes series endpoint proxying as ThanosSeriesResponse.Data used LabelSet which has no UnmarshalJSON (simply changing to ZLabelSet).