Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query frontend to the quickstart script #3372

Closed
wants to merge 2 commits into from
Closed

Add query frontend to the quickstart script #3372

wants to merge 2 commits into from

Conversation

vears91
Copy link

@vears91 vears91 commented Oct 27, 2020

Closes #3304

Signed-off-by: Victor Araujo [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

bwplotka
bwplotka requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

It looks amazing, except one thing that might be blocked first by #3373

scripts/quickstart.sh

sleep 0.5

${THANOS_EXECUTABLE} query-frontend \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how it suppose to work, unfortunately. Those replicas have to be separate for better horizontal scalability. This means there should be a load balancing in between - ideally round robin load balancer for better distribution.

We can add some nginx for it, but ideally, we could work towards this: #3373

Let me know if this makes sense 🤗

yeya24
yeya24 reviewed Oct 28, 2020
View reviewed changes
scripts/quickstart.sh Outdated
@@ -11,6 +11,9 @@ MC_EXECUTABLE=${MC_EXECUTABLE:-"mc"}
PROMETHEUS_EXECUTABLE=${PROMETHEUS_EXECUTABLE:-"prometheus"}
THANOS_EXECUTABLE=${THANOS_EXECUTABLE:-"thanos"}
S3_ENDPOINT=""
QUERY_FRONTEND_CACHE_MAX_SIZE=${QUERY_FRONTEND_CACHE_MAX_SIZE:-""}
QUERY_FRONTEND_CACHE_MAX_SIZE_ITEMS=${QUERY_FRONTEND_CACHE_MAX_SIZE_ITEMS:-0}
QUERY_FRONTEND_CACHE_VALIDITY=${QUERY_FRONTEND_CACHE_VALIDITY:-"0s"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 6h here

scripts/quickstart.sh Outdated
@@ -11,6 +11,9 @@ MC_EXECUTABLE=${MC_EXECUTABLE:-"mc"}
PROMETHEUS_EXECUTABLE=${PROMETHEUS_EXECUTABLE:-"prometheus"}
THANOS_EXECUTABLE=${THANOS_EXECUTABLE:-"thanos"}
S3_ENDPOINT=""
QUERY_FRONTEND_CACHE_MAX_SIZE=${QUERY_FRONTEND_CACHE_MAX_SIZE:-""}
QUERY_FRONTEND_CACHE_MAX_SIZE_ITEMS=${QUERY_FRONTEND_CACHE_MAX_SIZE_ITEMS:-0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set this to 2048

scripts/quickstart.sh Outdated
@@ -11,6 +11,9 @@ MC_EXECUTABLE=${MC_EXECUTABLE:-"mc"}
PROMETHEUS_EXECUTABLE=${PROMETHEUS_EXECUTABLE:-"prometheus"}
THANOS_EXECUTABLE=${THANOS_EXECUTABLE:-"thanos"}
S3_ENDPOINT=""
QUERY_FRONTEND_CACHE_MAX_SIZE=${QUERY_FRONTEND_CACHE_MAX_SIZE:-""}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set this to "0"

@vears91 vears91 force-pushed the add-query-frontend-quickstart branch from bf6058a to 3dc50f8 Compare November 2, 2020 21:29
@yeya24 yeya24 mentioned this pull request Dec 13, 2020
Open
@stale
Copy link

stale bot commented Jan 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 2, 2021
@stale stale bot closed this Jan 9, 2021
@kakkoyun
Copy link
Member

@vears91 Do you want to continue working on it? I can open it and give it another round of review. Sorry if we dropped the ball on this one.

@vears91
Copy link
Author

vears91 commented Feb 16, 2021

@vears91 Do you want to continue working on it? I can open it and give it another round of review. Sorry if we dropped the ball on this one.

Hi. I would like to, is #3373 still blocking this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 left review comments

@bwplotka bwplotka bwplotka requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query frontend component to the quickstart script
4 participants
@vears91 @kakkoyun @bwplotka @yeya24