-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receive/rule: Fixed Segfault issue; Added tests & benchmarks for TSDB Store, fixed multitsdb benchmarks. #3046
Conversation
fb84117
to
522d759
Compare
PTAL - this should be ready to go. It's blocking 0.15 release. |
Generally looking good, not too familiar with the surrounding code though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits in line.
pkg/store/storepb/testutil/series.go
Outdated
@@ -241,7 +220,7 @@ func TestServerSeries(t testutil.TB, store storepb.StoreServer, cases ...*Series | |||
srv := NewSeriesServer(context.Background()) | |||
testutil.Ok(t, store.Series(c.Req, srv)) | |||
testutil.Equals(t, len(c.ExpectedWarnings), len(srv.Warnings), "%v", srv.Warnings) | |||
testutil.Equals(t, len(c.ExpectedSeries), len(srv.SeriesSet)) | |||
//testutil.Equals(t, len(c.ExpectedSeries), len(srv.SeriesSet)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important bug, we should have it and uncomment, thanks!
8d3e1b3
to
267ee04
Compare
Looking on different frame limits it's really close... However actually now it shows 1MB being bit better one...
|
Another one:
|
4922fbd
to
a693a66
Compare
OK, extensive tests shows really not much difference, so sticking to 1MB limit as it was previously (:
|
This is without marshalling - will do marshalling later on |
…Store, fixed multitsdb benchmarks. Fixed #3013 Also: * Fixed other quite big issue with reusing chunk slice. * Fixed framing - previously it was wrongly sending single-chunk frames, taking huge amount of time. Fix: We deletage closer now to ensure multitsdb operate on valid data. Signed-off-by: Bartlomiej Plotka <[email protected]> # Conflicts: # pkg/store/tsdb_test.go # pkg/testutil/testutil.go
Fixed #3013
Also:
huge amount of time.
Fix: We deletage closer now to ensure multitsdb operate on valid data.
Signed-off-by: Bartlomiej Plotka [email protected]