-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Reuse operation name constants for consistency #2991
Conversation
Signed-off-by: Kemal Akkoyun <[email protected]>
2daf456
to
e468a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on green
@@ -29,12 +29,6 @@ import ( | |||
const ( | |||
originCache = "cache" | |||
originBucket = "bucket" | |||
|
|||
opGet = "get" | |||
opGetRange = "getrange" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually mismatching what we have already for bucket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! I think we should mention this change in the CHANGELOG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any mixin / alert we could change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing, I could find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a comment about CHANGELOG.
@@ -29,12 +29,6 @@ import ( | |||
const ( | |||
originCache = "cache" | |||
originBucket = "bucket" | |||
|
|||
opGet = "get" | |||
opGetRange = "getrange" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! I think we should mention this change in the CHANGELOG
Signed-off-by: Kemal Akkoyun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Let's merge after we check if we can update any mixin (:
@@ -29,12 +29,6 @@ import ( | |||
const ( | |||
originCache = "cache" | |||
originBucket = "bucket" | |||
|
|||
opGet = "get" | |||
opGetRange = "getrange" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any mixin / alert we could change?
@bwplotka Mixin seems ok. We don't have any usage. So merging it. |
Signed-off-by: Kemal Akkoyun [email protected]
Verification
make test-local