Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(release branch) query: irate and resets use now counter downsampling aggregations. #2719

Merged
merged 1 commit into from
Jun 4, 2020
Merged

(release branch) query: irate and resets use now counter downsampling aggregations. #2719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#2525](https://github.com/thanos-io/thanos/pull/2525) Query: Fixed logging for dns resolution error in the `Query` component.
- [#2484](https://github.com/thanos-io/thanos/pull/2484) Query/Ruler: Fixed issue #2483, when web.route-prefix is set, it is added twice in HTTP router prefix.
- [#2416](https://github.com/thanos-io/thanos/pull/2416) Bucket: Fixed issue #2416 bug in `inspect --sort-by` doesn't work correctly in all cases
- [#2719](https://github.com/thanos-io/thanos/pull/2719) Store: `irate` and `resets` use now counter downsampling aggregations.

### Added

Expand Down
2 changes: 1 addition & 1 deletion pkg/query/querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func aggrsFromFunc(f string) []storepb.Aggr {
if strings.HasPrefix(f, "sum_") {
return []storepb.Aggr{storepb.Aggr_SUM}
}
if f == "increase" || f == "rate" {
if f == "increase" || f == "rate" || f == "irate" || f == "resets" {
return []storepb.Aggr{storepb.Aggr_COUNTER}
}
// In the default case, we retrieve count and sum to compute an average.
Expand Down