Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Fix broken Make action dependencies #2680

Merged
merged 1 commit into from
May 29, 2020

Conversation

kakkoyun
Copy link
Member

Signed-off-by: Kemal Akkoyun [email protected]

Fixes dependency name discrepancies between .bingo/Variables.mk and Makefile.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Fixes dependency name discrepancies between .bingo/Variables.mk and Makefile.

Verification

  • make install-deps
  • make test-local

@kakkoyun kakkoyun requested a review from bwplotka May 28, 2020 16:23
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's was so easy to miss. Still some CI issues though 🤗

@bwplotka
Copy link
Member

@brancz brancz merged commit 6dcdf11 into thanos-io:master May 29, 2020
@kakkoyun kakkoyun deleted the fix_make_deps branch May 29, 2020 08:42
thisisobate pushed a commit to thisisobate/thanos that referenced this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants