compactor: Put important compaction logs as info; init object store metrics. #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
info-compact
branch
2 times, most recently
from
c18bca5 to
72be658
Compare
bwplotka
changed the title
GiedriusS
reviewed
Feb 20, 2020
pkg/objstore/objstore.go
Outdated
| bkt.opsFailures.WithLabelValues(op) | ||
| bkt.opsDuration.WithLabelValues(op) | ||
| } | ||
| bkt.lastSuccessfullUploadTime.WithLabelValues(b.Name()) |
There was a problem hiding this comment.
I know you haven't introduced this but maybe we should fix this typo as well while changing this so that it would be lastSuccessfulUploadTime? :P
GiedriusS
approved these changes
Feb 20, 2020
brancz
approved these changes
Feb 21, 2020
…etrics. Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
force-pushed
the
info-compact
branch
from
72be658 to
55c744e
Compare
brancz
approved these changes
Feb 21, 2020
vankop
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Feb 28, 2020
…etrics. (thanos-io#2162) Signed-off-by: Bartlomiej Plotka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka [email protected]