Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault panic. #2153

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fix segfault panic. #2153

merged 1 commit into from
Feb 19, 2020

Conversation

IKSIN
Copy link
Contributor

@IKSIN IKSIN commented Feb 19, 2020

  • Fixed segmentation violation in proxy.go

Changes

Verification

@IKSIN
Fix segfault panic.
9f8a080 
Signed-off-by: Aleskey Sin <[email protected]>
@IKSIN IKSIN requested a review from bwplotka February 19, 2020 10:50
bwplotka
bwplotka approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@bwplotka bwplotka merged commit c39ddb2 into thanos-io:master Feb 19, 2020
@metalmatze metalmatze mentioned this pull request Feb 19, 2020
Merged
vankop pushed a commit to monitoring-tools/thanos that referenced this pull request Feb 28, 2020
@IKSIN @vankop
Fix segfault panic. (thanos-io#2153)
d7e557c 
Signed-off-by: Aleskey Sin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IKSIN @brancz @bwplotka