Updated Prometheus deps to master around 2.15.2 tag. #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
approved these changes
Jan 7, 2020
|
Did you go through this PR @povilasv in details ? ;p I made same mistake again (did similar in previous also approved PRs):
It's non-obvious PR so want to be careful here. (: |
bwplotka
force-pushed
the
pull-latest-prom
branch
from
907bba8
to
d82ffa1
Compare
I did 2x times and IMO it's ok 👍 but obviously needs some review more familiar with the code base :) |
squat
reviewed
Jan 7, 2020
pkg/block/indexheader/json_reader.go
Outdated
| castagnoliTable = crc32.MakeTable(crc32.Castagnoli) | ||
| } | ||
|
|
||
| // ReadSymbols reads the symbol table fully into memory and allocates proper strings for them. |
squat
approved these changes
Jan 7, 2020
Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
force-pushed
the
pull-latest-prom
branch
from
d82ffa1
to
d384d27
Compare
|
@povilasv double checking (: Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1935
Fixes: #1928
Fixes: #722
Fixes: #1771
Needed for index-header but mainly this makes compaction and downsampling process taking constant memory! It will take more time though as a tradeoff.
Now it should take at max:
Help in verifying this on a bigger setup would be nice! (:
Signed-off-by: Bartlomiej Plotka [email protected]