Add a wal compression flag in rule and receive #1933
Conversation
|
Should it be a flag? Receiver sets this option to |
|
It is an option in Prometheus, plus false by default, so I would stick to the same here. You are right for the receiver - we might want the option as well. |
|
OK. I will add the flag for ruler and receiver in this PR. |
yeya24
force-pushed
the
add-wal-compress
branch
from
355d7d2
to
73999e6
Compare
|
I have added a flag for rule and receive. Should I add the changelog? |
|
Definitely worth mentioning in changelog if the default has changed |
yeya24
changed the title
yeya24
force-pushed
the
add-wal-compress
branch
from
73999e6
to
e99000f
Compare
|
WAL compression is intended to become the default in Prometheus, we just can't do it in Prometheus yet as that would be too breaking of a change. I personally think we should just always have WAL compression enabled, the CPU footprint of receive is so tiny it's the right trade-off in my opinion. tl;dr I think we should leave things as they are in this regard. |
|
Should we make it true by default then? |
|
I'm not sure this should be configurable at all, but yes if this config option exists then it should definitely be true by default. |
cmd/thanos/receive.go
Outdated
| @@ -73,6 +72,8 @@ func registerReceive(m map[string]setupFunc, app *kingpin.Application) { | |||
|
|
|||
| tsdbBlockDuration := modelDuration(cmd.Flag("tsdb.block-duration", "Duration for local TSDB blocks").Default("2h").Hidden()) | |||
|
|
|||
| walCompression := cmd.Flag("tsdb.wal-compression", "Compress the tsdb WAL.").Default("false").Bool() | |||
There was a problem hiding this comment.
Let's have true by default then
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
add-wal-compress
branch
from
e99000f
to
7543bdc
Compare
Signed-off-by: yeya24 [email protected]
Changes
Add a WAL compression option in rule and receive
Verification