Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support post method in /api/v1/labels #1910

Merged
merged 1 commit into from
Dec 20, 2019
Merged

support post method in /api/v1/labels #1910

merged 1 commit into from
Dec 20, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 18, 2019

Signed-off-by: yeya24 [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

We should support both GET and POST method in /api/v1/labels.

Verification

jojohappy
jojohappy approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@jojohappy jojohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 19, 2019

Seems there is a flaky test TestCacheAddresses, https://circleci.com/gh/yeya24/thanos/36?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@bwplotka
Copy link
Member

That's a new thing, worth to report as issue (:

But it's super weird as I cannot restart it - CI runs on your fork.. Did you set up something additionally for your fork?

bwplotka
bwplotka approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once CI passes (:

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 20, 2019

@bwplotka Hi, I reset my fork setting and I guess you can retrigger it now. Could you please re-trigger the CI since it fails agian?

@bwplotka bwplotka merged commit ed6087f into thanos-io:master Dec 20, 2019
@yeya24 yeya24 deleted the add-post branch December 20, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojohappy jojohappy jojohappy approved these changes

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeya24 @bwplotka @jojohappy