Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user-agent in http header. #1867

Merged
merged 1 commit into from
Dec 11, 2019
Merged

add user-agent in http header. #1867

merged 1 commit into from
Dec 11, 2019

Conversation

johncming
Copy link
Contributor

add user-agent in http header.

GiedriusS
GiedriusS approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a nice improvement! This also makes sure we follow the same convention that Prometheus does when sending an alert. Thank you.

@bwplotka bwplotka merged commit 80c23db into thanos-io:master Dec 11, 2019
@bwplotka
Copy link
Member

Would be nice to have CHANGELOG for this (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
component: rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johncming @bwplotka @GiedriusS