Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote sidecar shipper.upload-compacted flag to non hidden, non experimental state. #1833

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Dec 3, 2019

Signed-off-by: Bartek Plotka [email protected]

Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar nits

@@ -93,6 +93,11 @@ thanos sidecar \

* _[Example Kubernetes manifests using Prometheus operator](https://github.com/coreos/prometheus-operator/tree/master/example/thanos)_

### Uploading old metrics.

When sidecar is ran wit `--shipper.upload-compacted` flag it will sync all older existing blocks from the Prometheus local storage on startup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the sidecar is run with the --...

### Uploading old metrics.

When sidecar is ran wit `--shipper.upload-compacted` flag it will sync all older existing blocks from the Prometheus local storage on startup.
NOTE: This assumes you never run sidecar with block uploading against this bucket. Otherwise manual steps are needed to remove overlapping blocks from bucket.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... from the bucket.

docs/quick-tutorial.md Outdated Show resolved Hide resolved
@squat
Copy link
Member

squat commented Dec 4, 2019

Hmm could we have a race?

storeset_test.go:476:

	exp: 15

	got: 14

--- FAIL: TestStoreSet_Update (4.02s)
FAIL
FAIL	github.com/thanos-io/thanos/pkg/query	8.073s

@bwplotka
Copy link
Member Author

bwplotka commented Dec 5, 2019

@squat Will look on that. Not introduced by this PR for sure (:

@bwplotka bwplotka merged commit fd01026 into master Dec 5, 2019
@squat squat deleted the old-metrics branch December 5, 2019 10:21
@squat
Copy link
Member

squat commented Dec 5, 2019

Yes that’s for sure. We’ll need to do a bit of digging to identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants