server: shutdown the actual http server #1689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi friends! It seems like #1680 introduced a regression that was preventing Thanos from shutting down cleanly. This fixes it. I did not add a CHANGELOG entry because, well, it's a regression which we fixed early. Let me know if you need me to add one.
Changes
Commit message inline for your convenience:
Verification
Manually verified that
thanos
can now be shutdown with a shutdown signal.cc @antonio