Pinned x/sys to certain version that is buildable for windows platform
#1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
changed the title
x/sys to certain version that is buildable for windows platformx/sys to certain version that is buildable for windows platform
|
Still crossbuild is not happy: |
…orm. Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
force-pushed
the
upgrade-deps
branch
from
d2eab58 to
6c37740
Compare
bwplotka
added a commit
that referenced
this pull request
Oct 14, 2019
…orm. (#1626) Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
added a commit
that referenced
this pull request
Oct 14, 2019
…ase 0.8.1 (#1640) * Pinned `x/sys` to certain version that is buildable for windows platform. (#1626) Signed-off-by: Bartek Plotka <[email protected]> * Post release update. (#1628) Signed-off-by: Bartek Plotka <[email protected]> * Removed Querier duplicate labels checks & made sure store will be not blocked for older Queriers. Changes: * Cleaned up the code a bit. * Ensured proper locks. * thanos_store_nodes_grpc_connections is not per store type and external labels. thanos_store_node_info is marked as deprecated. * Added (optional, but enabled by default) compatibility label to store GW Info method with flag to disable it. Store only adds it if there is any labelset to advertise. * Disabled any strict deduplication in external labels detection; just warning! * More tests; compatibility tests for query pre 0.8.0 and new store GW. * Remove compatibility label if spotted. Fixes #1632 Signed-off-by: Bartek Plotka <[email protected]> * Changelog fixes (#1634) Signed-off-by: Bartek Plotka <[email protected]>
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
…orm. (#1626) Signed-off-by: Bartek Plotka <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: https://circleci.com/gh/thanos-io/thanos/5257?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification
Signed-off-by: Bartek Plotka [email protected]