Compact resolution/retention docs update. #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Sep 20, 2019
|
@bwplotka so I'd add exact list of aggregations that happen, or at least link to the code where a user might find it and after that - merge it. |
ivan-kiselev
force-pushed
the
master
branch
2 times, most recently
from
effada2
to
369c860
Compare
|
Jesus heck how do I sign-off that nasty commit? |
ivan-kiselev
force-pushed
the
master
branch
4 times, most recently
from
01a4348
to
2e461e7
Compare
Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Ivan Kiselev <[email protected]>
accept PR suggestions Co-Authored-By: Bartlomiej Plotka <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Matthias Loibl <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Ivan Kiselev <[email protected]>
* Add prober to receive Signed-off-by: Kemal Akkoyun <[email protected]> * Add changelog entries Signed-off-by: Kemal Akkoyun <[email protected]> * Update README Signed-off-by: Kemal Akkoyun <[email protected]> * Remove default Signed-off-by: Kemal Akkoyun <[email protected]> * Wait hashring to be ready Signed-off-by: Kemal Akkoyun <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
* Add readiness and liveness probes for downsampler Signed-off-by: Kemal Akkoyun <[email protected]> * Add changelog entry Signed-off-by: Kemal Akkoyun <[email protected]> * Remove default Signed-off-by: Kemal Akkoyun <[email protected]> * Set ready Signed-off-by: Kemal Akkoyun <[email protected]> * Update CHANGELOG Signed-off-by: Kemal Akkoyun <[email protected]> * Clean CHANGELOG Signed-off-by: Kemal Akkoyun <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Antonio Santos <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Martin Chodur <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
It's the largest streaming service in India that does cricket and GoT for India. They have insane scale and are using Thanos to scale their Prometheus. Spoke to them offline about adding the logo and will get a signoff here too. Signed-off-by: Goutham Veeramachaneni <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
Signed-off-by: Karthik Vijayaraju <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
… text. (thanos-io#1552) Signed-off-by: Callum Styan <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
… directory (thanos-io#1544) * Ignore object if it is the current directory Signed-off-by: Jamie Poole <[email protected]> * Add full-stop Signed-off-by: Jamie Poole <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
…io#1555) Signed-off-by: Leo Meira Vital <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
The format of these files is wrong in the web. Signed-off-by: dongwenjuan <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
* compact: unify different time constants Use downsample.* constants where possible. Move the downsampling time ranges into constants and use them as well. Signed-off-by: Giedrius Statkevičius <[email protected]> * bucket: refactor column calculation into compact Fix the column's name and name it UNTIL-DOWN because that is what it actually shows - time until the next downsampling. Move out the calculation into a separate function into the compact package. Ideally we could use the retention policies in this calculation as well but the `bucket` subcommand knows nothing about them :-( Signed-off-by: Giedrius Statkevičius <[email protected]> * compact: fix issues with naming Reorder the constants and fix mistakes. Signed-off-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]>
ivan-kiselev
force-pushed
the
master
branch
from
2e461e7
to
d8cd9b9
Compare
Signed-off-by: Ivan Kiselev <[email protected]>
|
oh I figured it. Gosh, I'm bad with git. |
|
I don't think I have merge permissions, so you gotta click the button folks |
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Some updates to compact docs Signed-off-by: Ivan Kiselev <[email protected]> * some formatting Signed-off-by: Ivan Kiselev <[email protected]> * Update docs/components/compact.md accept PR suggestions Co-Authored-By: Bartlomiej Plotka <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Add metalmatze to list of maintainers (#1547) Signed-off-by: Matthias Loibl <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * resolve comments Signed-off-by: Ivan Kiselev <[email protected]> * resolve last comment Signed-off-by: Ivan Kiselev <[email protected]> * receive: Add liveness and readiness probe (#1537) * Add prober to receive Signed-off-by: Kemal Akkoyun <[email protected]> * Add changelog entries Signed-off-by: Kemal Akkoyun <[email protected]> * Update README Signed-off-by: Kemal Akkoyun <[email protected]> * Remove default Signed-off-by: Kemal Akkoyun <[email protected]> * Wait hashring to be ready Signed-off-by: Kemal Akkoyun <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * downsample: Add liveness and readiness probe (#1540) * Add readiness and liveness probes for downsampler Signed-off-by: Kemal Akkoyun <[email protected]> * Add changelog entry Signed-off-by: Kemal Akkoyun <[email protected]> * Remove default Signed-off-by: Kemal Akkoyun <[email protected]> * Set ready Signed-off-by: Kemal Akkoyun <[email protected]> * Update CHANGELOG Signed-off-by: Kemal Akkoyun <[email protected]> * Clean CHANGELOG Signed-off-by: Kemal Akkoyun <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Document the dnssrvnoa option (#1551) Signed-off-by: Antonio Santos <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * feat store: added readiness and livenes prober (#1460) Signed-off-by: Martin Chodur <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Add Hotstar to adopters. (#1553) It's the largest streaming service in India that does cricket and GoT for India. They have insane scale and are using Thanos to scale their Prometheus. Spoke to them offline about adding the logo and will get a signoff here too. Signed-off-by: Goutham Veeramachaneni <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Fix hotstar logo in the adoptor's list (#1558) Signed-off-by: Karthik Vijayaraju <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Fix typos, including 'fomrat' -> 'format' in tracing.config-file help text. (#1552) Signed-off-by: Callum Styan <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Compactor: Fix for #844 - Ignore object if it is the current directory (#1544) * Ignore object if it is the current directory Signed-off-by: Jamie Poole <[email protected]> * Add full-stop Signed-off-by: Jamie Poole <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Adding doc explaining the importance of groups for compactor (#1555) Signed-off-by: Leo Meira Vital <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Add blank line for list (#1566) The format of these files is wrong in the web. Signed-off-by: dongwenjuan <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * Refactor compactor constants, fix bucket column (#1561) * compact: unify different time constants Use downsample.* constants where possible. Move the downsampling time ranges into constants and use them as well. Signed-off-by: Giedrius Statkevičius <[email protected]> * bucket: refactor column calculation into compact Fix the column's name and name it UNTIL-DOWN because that is what it actually shows - time until the next downsampling. Move out the calculation into a separate function into the compact package. Ideally we could use the retention policies in this calculation as well but the `bucket` subcommand knows nothing about them :-( Signed-off-by: Giedrius Statkevičius <[email protected]> * compact: fix issues with naming Reorder the constants and fix mistakes. Signed-off-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Ivan Kiselev <[email protected]> * remove duplicate Signed-off-by: Ivan Kiselev <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A little update of compactor documentation related to Resolution and retention with a hope that fewer people are going to get confused in the future.
Related to #813