pkg/ui: Upgrade bootstrap typeahead to v4.0.2 #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Branczyk <[email protected]>
brancz
force-pushed
the
bootstrap-typeahead
branch
from
1ba6c65
to
11308f9
Compare
GiedriusS
reviewed
Aug 14, 2019
| @@ -7,8 +7,6 @@ TMP_GOPATH ?= /tmp/thanos-go | |||
| GOBIN ?= ${GOPATH}/bin | |||
| GO111MODULE ?= on | |||
| export GO111MODULE | |||
| GOPROXY ?= https://proxy.golang.org | |||
There was a problem hiding this comment.
Why are we removing the proxy here? (:
There was a problem hiding this comment.
Otherwise we have a failing build, the same reason why we had to update to a newer tsdb here: #1380
But I didn't want to update to a newer tsdb for a patch release.
There was a problem hiding this comment.
We need that. It's also only for 0.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates bootstrap typeahead to v4.0.2
Verification
Tested that typeahead still works.
@bwplotka @povilasv @GiedriusS @domgreen