Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/series: return an empty array iff no results #1327

Merged
merged 1 commit into from
Jul 15, 2019
Merged

api/series: return an empty array iff no results #1327

merged 1 commit into from
Jul 15, 2019

Commits on Jul 13, 2019

  1. api/v1: return an empty array iff no results 

    Prometheus' /series end-point returns an empty array no matter what: if
there were results or not. We need to follow the same principle in
Thanos as well because our users depend on it.

The same fix has been applied like here:
https://github.com/prometheus/prometheus/blob/fef150f1b5e48652ec6779e2129ae9a0cf13db8a/web/api/v1/api.go#L506

Tests have been updated to account for this difference and plus one test
has been added just for this case.

Closes thanos-io#1325.
    @GiedriusS
    GiedriusS committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    9310949 View commit details
    Browse the repository at this point in the history