-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sidecar: Added support for streaming, chunked remote read. #1268
Conversation
f5ddb66
to
9fb1f3f
Compare
7bd205f
to
cedf673
Compare
04bfeda
to
acf922d
Compare
6243e4d
to
4f31ca5
Compare
ef5d17b
to
a460fa6
Compare
431aaf5
to
e57811c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point me to the test that ensure a good behavior when the x-streamed-protobuf
returns multi frames?
c216e97
to
d7b4aef
Compare
@krasi-georgiev The merging multi series frame are tested in proxy code here: https://github.com/thanos-io/thanos/blob/master/pkg/store/proxy_test.go#L70 But adding more testcases. |
Started discussion on the StoreAPI Series API invariant aka |
Changed this accordingly to #1464 decision. CC @krasi-georgiev |
Fixes: #488 Signed-off-by: Bartek Plotka <[email protected]>
Fixes: #488
Signed-off-by: Bartek Plotka [email protected]