pkg/receive: register handler metrics #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thanos receive component instruments its handler with some metrics but these metrics are currently never registered.
|
Oh my. Second time in two days. Someone really should invest in some static tooling to try to catch common mistakes like this. lgtm 👍 |
brancz
approved these changes
Jun 19, 2019
|
As a side note, but should be done in a separate PR .. we probably want metrics for requests total |
squat
added a commit
to squat/thanos
that referenced
this pull request
Jun 19, 2019
As per the discussion in thanos-io#1261 (comment), let's add a metric to track the total number of requests handled by the receive component.
brancz
pushed a commit
that referenced
this pull request
Jun 19, 2019
As per the discussion in #1261 (comment), let's add a metric to track the total number of requests handled by the receive component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thanos receive component instruments its handler with some metrics
but these metrics are currently never registered.
Changes
Register the receive handler metrics with the given registerer during creation.
Verification
Scrape the receive component's /metrics endpoint to verify that the handler metrics are now present.
cc @brancz @bwplotka