Propagate retriable/haltable errors from compactor #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, although this will fix compact exiting, the work the compactor has written to disk is thrown away when the compaction is retried. I'm thinking about a good way to avoid this - the simplest thing would be to just retry the bucket requests more times before returning an error. |
|
|
|
@GiedriusS sure, I can use that instead 👍 |
|
Updated, I'll squash the commits if we're happy to proceed. |
bwplotka
requested changes
May 30, 2019
povilasv
previously requested changes
May 31, 2019
Previously, a new error was created from all worker errors so the custom type was not propagated. If all errors returned are retriable, we assume it is safe to retry the compaction. Since the compactor may still return a single error this logic is preserved.
mattrco
force-pushed
the
mattrco/propagate-retries
branch
from
a1e8191
to
3dfb893
Compare
|
Rebased this against master and updated the import path against tsdb 0.8.0 👍 |
mattrco
force-pushed
the
mattrco/propagate-retries
branch
from
f89f92f
to
a658dbf
Compare
FUSAKLA
pushed a commit
to FUSAKLA/thanos
that referenced
this pull request
Jun 8, 2019
* Propagate retriable/haltable errors from compactor Previously, a new error was created from all worker errors so the custom type was not propagated. If all errors returned are retriable, we assume it is safe to retry the compaction. Since the compactor may still return a single error this logic is preserved. * Update MultiError import for tsdb 0.8.0 * Update import path in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We observed thanos compactor was exiting on upload errors. Previously, a new
error was created from all worker errors so the custom type was not propagated.
This introduces
go-multierrorto preserve the error types.If all errors returned are retriable, it is safe to retry the compaction.
Since the compactor may still return a single error this logic is preserved.
(Happy to refactor out the duplicated logic with individual error checks.)
Verification
Tests are passing and I'll run this change with real workloads shortly.