Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subqueries don't work with pushdown at the moment #5600

Closed
GiedriusS opened this issue Aug 17, 2022 · 2 comments
Closed

Subqueries don't work with pushdown at the moment #5600

GiedriusS opened this issue Aug 17, 2022 · 2 comments

Comments

@GiedriusS
Copy link
Member

See prometheus/prometheus#11162 for information.

GiedriusS added a commit to vinted/thanos that referenced this issue Aug 17, 2022
Repro for thanos-io#5600.

Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS added a commit to vinted/thanos that referenced this issue Aug 17, 2022
Repro for thanos-io#5600.

Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS added a commit to vinted/thanos that referenced this issue Sep 28, 2022
Repro for thanos-io#5600.

Signed-off-by: Giedrius Statkevičius <[email protected]>
bwplotka pushed a commit that referenced this issue Oct 7, 2022
* e2e: add tests for pushed down subqueries

Repro for #5600.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: update dependency

Update prometheus dependency.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* test: fix test

Signed-off-by: Giedrius Statkevičius <[email protected]>

* Upgrade Prometheus to v2.39.0

Signed-off-by: Douglas Camata <[email protected]>

* Fix UnRegisterer to work well when it's wrapped

Signed-off-by: Douglas Camata <[email protected]>

* Update CHANGELOG

Signed-off-by: Douglas Camata <[email protected]>

* Fix UnRegisterer creation

Signed-off-by: Douglas Camata <[email protected]>

* Fix e2e env name to comply with new rules

Signed-off-by: Douglas Camata <[email protected]>

* Remove query pushdown test case

Signed-off-by: Douglas Camata <[email protected]>

* Fix compactor relabeling after Prometheus upgrade

Signed-off-by: Douglas Camata <[email protected]>

* Fix tsdb.NewHead call after wbl addition

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
Co-authored-by: Giedrius Statkevičius <[email protected]>
utukJ pushed a commit to utukJ/thanos that referenced this issue Oct 13, 2022
* e2e: add tests for pushed down subqueries

Repro for thanos-io#5600.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: update dependency

Update prometheus dependency.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* test: fix test

Signed-off-by: Giedrius Statkevičius <[email protected]>

* Upgrade Prometheus to v2.39.0

Signed-off-by: Douglas Camata <[email protected]>

* Fix UnRegisterer to work well when it's wrapped

Signed-off-by: Douglas Camata <[email protected]>

* Update CHANGELOG

Signed-off-by: Douglas Camata <[email protected]>

* Fix UnRegisterer creation

Signed-off-by: Douglas Camata <[email protected]>

* Fix e2e env name to comply with new rules

Signed-off-by: Douglas Camata <[email protected]>

* Remove query pushdown test case

Signed-off-by: Douglas Camata <[email protected]>

* Fix compactor relabeling after Prometheus upgrade

Signed-off-by: Douglas Camata <[email protected]>

* Fix tsdb.NewHead call after wbl addition

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
Co-authored-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: utukj <[email protected]>
@yeya24
Copy link
Contributor

yeya24 commented Oct 22, 2022

@GiedriusS As the upstream PR has been merged, do we have any next steps?

@GiedriusS
Copy link
Member Author

No, this works now, at least in my testing so I think we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants