-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subqueries don't work with pushdown at the moment #5600
Labels
Comments
GiedriusS
added
feature request/improvement
component: query
bug
and removed
feature request/improvement
labels
Aug 17, 2022
GiedriusS
added a commit
to vinted/thanos
that referenced
this issue
Aug 17, 2022
Repro for thanos-io#5600. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
to vinted/thanos
that referenced
this issue
Aug 17, 2022
Repro for thanos-io#5600. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
to vinted/thanos
that referenced
this issue
Sep 28, 2022
Repro for thanos-io#5600. Signed-off-by: Giedrius Statkevičius <[email protected]>
bwplotka
pushed a commit
that referenced
this issue
Oct 7, 2022
* e2e: add tests for pushed down subqueries Repro for #5600. Signed-off-by: Giedrius Statkevičius <[email protected]> * *: update dependency Update prometheus dependency. Signed-off-by: Giedrius Statkevičius <[email protected]> * test: fix test Signed-off-by: Giedrius Statkevičius <[email protected]> * Upgrade Prometheus to v2.39.0 Signed-off-by: Douglas Camata <[email protected]> * Fix UnRegisterer to work well when it's wrapped Signed-off-by: Douglas Camata <[email protected]> * Update CHANGELOG Signed-off-by: Douglas Camata <[email protected]> * Fix UnRegisterer creation Signed-off-by: Douglas Camata <[email protected]> * Fix e2e env name to comply with new rules Signed-off-by: Douglas Camata <[email protected]> * Remove query pushdown test case Signed-off-by: Douglas Camata <[email protected]> * Fix compactor relabeling after Prometheus upgrade Signed-off-by: Douglas Camata <[email protected]> * Fix tsdb.NewHead call after wbl addition Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]>
utukJ
pushed a commit
to utukJ/thanos
that referenced
this issue
Oct 13, 2022
* e2e: add tests for pushed down subqueries Repro for thanos-io#5600. Signed-off-by: Giedrius Statkevičius <[email protected]> * *: update dependency Update prometheus dependency. Signed-off-by: Giedrius Statkevičius <[email protected]> * test: fix test Signed-off-by: Giedrius Statkevičius <[email protected]> * Upgrade Prometheus to v2.39.0 Signed-off-by: Douglas Camata <[email protected]> * Fix UnRegisterer to work well when it's wrapped Signed-off-by: Douglas Camata <[email protected]> * Update CHANGELOG Signed-off-by: Douglas Camata <[email protected]> * Fix UnRegisterer creation Signed-off-by: Douglas Camata <[email protected]> * Fix e2e env name to comply with new rules Signed-off-by: Douglas Camata <[email protected]> * Remove query pushdown test case Signed-off-by: Douglas Camata <[email protected]> * Fix compactor relabeling after Prometheus upgrade Signed-off-by: Douglas Camata <[email protected]> * Fix tsdb.NewHead call after wbl addition Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: utukj <[email protected]>
@GiedriusS As the upstream PR has been merged, do we have any next steps? |
No, this works now, at least in my testing so I think we can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See prometheus/prometheus#11162 for information.
The text was updated successfully, but these errors were encountered: