Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate failinit. #2142

Closed
bwplotka opened this issue Feb 16, 2020 · 3 comments · Fixed by #2143
Closed

Incorporate failinit. #2142

bwplotka opened this issue Feb 16, 2020 · 3 comments · Fixed by #2143
Labels
beer difficulty: easy feature request/improvement good first issue help wanted

Comments

@bwplotka
Copy link
Member

Hi,

I would propose adding https://github.com/fatih/faillint/blob/master/README.md to our 'make lint' rule to avoid some inconsistencies like some packages we would like to not import:

  • errors (we use pkg/errors)
  • prometheus/tsdb (it was archived and moved to Prometheus module)
  • prometheus/prometheus/pkg/testutils (we have our own)

Help wanted 🤗
@kadern0
Copy link
Contributor

kadern0 commented Feb 17, 2020

I'd be happy to help on this one

kadern0 added a commit to kadern0/thanos that referenced this issue Feb 17, 2020
@kadern0
Added failint to make lint
b22ef24 
Fixes thanos-io#2142
@kadern0 kadern0 mentioned this issue Feb 17, 2020
Merged
2 tasks
kadern0 added a commit to kadern0/thanos that referenced this issue Feb 19, 2020
@kadern0
Added failint to make lint
0ec2a16 
Fixes thanos-io#2142

Signed-off-by: kaderno <[email protected]>
@bwplotka
Copy link
Member Author

🎉

@bwplotka
Copy link
Member Author

bwplotka commented Mar 6, 2020

At some point it would be nice to add prometheus client main package to not allowed list and only rely on promauto. This way we can ensure all our metrics are registered! 🤙 We might need/contribute this to make this happen: fatih/faillint#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beer difficulty: easy feature request/improvement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: add faillint to lint target - Issue 2142 kadern0/thanos
2 participants
@bwplotka @kadern0