fixup! fixup! fixup! reloader: allow suppressing envvar errors

Signed-off-by: Pranshu Srivastava <[email protected]>

.mdox.validate.yaml

@@ -42,5 +42,5 @@ validators:
     type: 'ignore'
   - regex: 'twitter\.com'
     type: 'ignore'
-  - regex: 'outshift.cisco.com/blog/multi-cluster-monitoring'
+  - regex: 'outshift\.cisco\.com\/blog\/multi-cluster-monitoring'
     type: 'ignore'

CHANGELOG.md

@@ -17,6 +17,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 
 ### Added
 
+- [#7429](https://github.com/thanos-io/thanos/pull/7429): Reloader: introduce `TolerateEnvVarExpansionErrors` to allow suppressing errors when expanding environment variables in the configuration file. When set, this will ensure that the reloader won't consider the operation to fail when an unset environment variable is encountered. Note that all unset environment variables are left as is, whereas all set environment variables are expanded as usual.
 - [#7317](https://github.com/thanos-io/thanos/pull/7317) Tracing: allow specifying resource attributes for the OTLP configuration.
 - [#7367](https://github.com/thanos-io/thanos/pull/7367) Store Gateway: log request ID in request logs.
 - [#7361](https://github.com/thanos-io/thanos/pull/7361) Query: *breaking :warning:* pass query stats from remote execution from server to client. We changed the protobuf of the QueryAPI, if you use `query.mode=distributed` you need to update your client (upper level Queriers) first, before updating leaf Queriers (servers).
@@ -26,7 +27,6 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 
 ### Changed
 
-- [#7429](https://github.com/thanos-io/thanos/pull/7429): Reloader: introduce `suppressEnvironmentVariablesExpansionErrors` to allow suppressing errors when expanding environment variables in the configuration file. When set, this will ensure that the reloader won't consider the operation to fail when an unset environment variable is encountered. Note that all unset environment variables are left as is, whereas all set environment variables are expanded as usual.
 - [#7334](https://github.com/thanos-io/thanos/pull/7334) Compactor: do not vertically compact downsampled blocks. Such cases are now marked with `no-compact-mark.json`. Fixes panic `panic: unexpected seriesToChunkEncoder lack of iterations`.
 - [#7393](https://github.com/thanos-io/thanos/pull/7393) *: *breaking :warning:* Using native histograms for grpc middleware metrics. Metrics `grpc_client_handling_seconds` and `grpc_server_handling_seconds` will now be native histograms, if you have enabled native histogram scraping you will need to update your PromQL expressions to use the new metric names.
 

pkg/reloader/reloader.go

@@ -237,7 +237,7 @@ func New(logger log.Logger, reg prometheus.Registerer, o *Options) *Reloader {
 		),
 		configEnvVarExpansionErrors: promauto.With(reg).NewGauge(
 			prometheus.GaugeOpts{
-				Name: "reloader_config_env_var_expansion_errors",
+				Name: "reloader_config_environment_variable_expansion_errors",
 				Help: "Number of environment variable expansions that failed during the last operation.",
 			},
 		),