add unit test

Signed-off-by: Srikrishna Paparaju <[email protected]>

pkg/logging/http.go

@@ -57,11 +57,11 @@ func (m *HTTPServerMiddleware) HTTPMiddleware(name string, next http.Handler) ht
 			}
 		}
 
-		var deciderUrl string = r.URL.String()
+		deciderURL := r.URL.String()
 		if len(port) > 0 {
-			deciderUrl = net.JoinHostPort(r.URL.String(), port)
+			deciderURL = net.JoinHostPort(deciderURL, port)
 		}
-		decision := m.opts.shouldLog(deciderUrl, nil)
+		decision := m.opts.shouldLog(deciderURL, nil)
 
 		switch decision {
 		case NoLogCall:

pkg/logging/http_test.go

@@ -64,4 +64,19 @@ func TestHTTPServerMiddleware(t *testing.T) {
 	testutil.Equals(t, 200, resp.StatusCode)
 	testutil.Equals(t, "Test Works", string(body))
 	testutil.Assert(t, !strings.Contains(b.String(), "err="))
+
+	// URL with no explicit port number in the format- hostname:port
+	req = httptest.NewRequest("GET", "http://example.com/foo", nil)
+	b.Reset()
+
+	w = httptest.NewRecorder()
+	hm(w, req)
+
+	resp = w.Result()
+	body, err = ioutil.ReadAll(resp.Body)
+	testutil.Ok(t, err)
+
+	testutil.Equals(t, 200, resp.StatusCode)
+	testutil.Equals(t, "Test Works", string(body))
+	testutil.Assert(t, !strings.Contains(b.String(), "err="))
 }