Calculating hashes by default

Signed-off-by: Pedro Tanaka <[email protected]>

pkg/store/bucket.go

@@ -99,6 +99,8 @@ const (
 	labelDecode = "decode"
 
 	minBlockSyncConcurrency = 1
+
+	enableChunkHashCalculation = true
 )
 
 var (
@@ -314,6 +316,8 @@ type BucketStore struct {
 
 	// Enables hints in the Series() response.
 	enableSeriesResponseHints bool
+
+	enableChunkHashCalculation bool
 }
 
 func (s *BucketStore) validate() error {
@@ -425,6 +429,7 @@ func NewBucketStore(
 		enableCompatibilityLabel:    enableCompatibilityLabel,
 		postingOffsetsInMemSampling: postingOffsetsInMemSampling,
 		enableSeriesResponseHints:   enableSeriesResponseHints,
+		enableChunkHashCalculation:  enableChunkHashCalculation,
 	}
 
 	for _, option := range options {
@@ -1104,7 +1109,7 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_Serie
 					req.MinTime, req.MaxTime,
 					req.Aggregates,
 					shardMatcher,
-					req.CalculateChunkChecksums,
+					s.enableChunkHashCalculation,
 				)
 				if err != nil {
 					return errors.Wrapf(err, "fetch series for block %s", b.meta.ULID)

pkg/store/prometheus_test.go

@@ -465,9 +465,8 @@ func TestPrometheusStore_Series_ChunkHashCalculation_Integration(t *testing.T) {
 	srv := newStoreSeriesServer(ctx)
 
 	testutil.Ok(t, proxy.Series(&storepb.SeriesRequest{
-		MinTime:                 baseT + 101,
-		MaxTime:                 baseT + 300,
-		CalculateChunkChecksums: true,
+		MinTime: baseT + 101,
+		MaxTime: baseT + 300,
 		Matchers: []storepb.LabelMatcher{
 			{Name: "a", Value: "b"},
 			{Type: storepb.LabelMatcher_EQ, Name: "region", Value: "eu-west"},
@@ -480,23 +479,6 @@ func TestPrometheusStore_Series_ChunkHashCalculation_Integration(t *testing.T) {
 		want := xxhash.Sum64(chunk.Raw.Data)
 		testutil.Equals(t, want, got)
 	}
-
-	// by default do not calculate the checksums
-	testutil.Ok(t, proxy.Series(&storepb.SeriesRequest{
-		MinTime: baseT + 101,
-		MaxTime: baseT + 300,
-		Matchers: []storepb.LabelMatcher{
-			{Name: "a", Value: "b"},
-			{Type: storepb.LabelMatcher_EQ, Name: "region", Value: "eu-west"},
-		},
-		CalculateChunkChecksums: false,
-	}, srv))
-	testutil.Equals(t, 2, len(srv.SeriesSet))
-	for _, chunk := range srv.SeriesSet[1].Chunks {
-		got := chunk.Raw.Hash
-		want := uint64(0)
-		testutil.Equals(t, want, got)
-	}
 }
 
 func TestPrometheusStore_Info(t *testing.T) {