use the main branch's implementation of MultiError

Signed-off-by: Yash Sharma <[email protected]>
thanos-io · Mar 11, 2021 · b05c9fd · b05c9fd
1 parent 7b0492f
commit b05c9fd
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 20 deletions.
diff --git a/pkg/errutil/multierror.go b/pkg/errutil/multierror.go
@@ -32,11 +32,6 @@ func (es MultiError) Err() error {
 	return NonNilMultiError(es)
 }
 
-// Error implements the error interface.
-func (es MultiError) Error() string {
-	return es.Err().Error()
-}
-
 type NonNilMultiError MultiError
 
 // Returns a concatenated string of the contained errors.

diff --git a/pkg/route/error.go b/pkg/route/error.go
@@ -38,7 +38,7 @@ func determineWriteErrorCause(err error, threshold int) error {
 	}
 
 	unwrappedErr := errors.Cause(err)
-	errs, ok := unwrappedErr.(errutil.MultiError)
+	errs, ok := unwrappedErr.(errutil.NonNilMultiError)
 	if !ok {
 		errs = []error{unwrappedErr}
 	}

diff --git a/pkg/route/handler.go b/pkg/route/handler.go
@@ -486,7 +486,7 @@ func (h *Handler) fanoutForward(pctx context.Context, tenant string, replicas ma
 			return fctx.Err()
 		case err, more := <-ec:
 			if !more {
-				return errs
+				return errs.Err()
 			}
 			if err == nil {
 				success++

diff --git a/pkg/route/handler_test.go b/pkg/route/handler_test.go
@@ -49,7 +49,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "nil multierror",
-			err:  errutil.MultiError([]error{}),
+			err:  errutil.NonNilMultiError([]error{}),
 		},
 		{
 			name:      "matching simple",
@@ -59,15 +59,15 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "non-matching multierror",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				errors.New("foo"),
 				errors.New("bar"),
 			}),
 			exp: errors.New("2 errors: foo; bar"),
 		},
 		{
 			name: "nested non-matching multierror",
-			err: errors.Wrap(errutil.MultiError([]error{
+			err: errors.Wrap(errutil.NonNilMultiError([]error{
 				errors.New("foo"),
 				errors.New("bar"),
 			}), "baz"),
@@ -76,9 +76,9 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "deep nested non-matching multierror",
-			err: errors.Wrap(errutil.MultiError([]error{
+			err: errors.Wrap(errutil.NonNilMultiError([]error{
 				errors.New("foo"),
-				errutil.MultiError([]error{
+				errutil.NonNilMultiError([]error{
 					errors.New("bar"),
 					errors.New("qux"),
 				}),
@@ -88,7 +88,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "matching multierror",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errors.New("foo"),
 				errors.New("bar"),
@@ -98,7 +98,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "matching but below threshold multierror",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errors.New("foo"),
 				errors.New("bar"),
@@ -108,7 +108,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "matching multierror many",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errConflict,
 				status.Error(codes.AlreadyExists, "conflict"),
@@ -120,7 +120,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "matching multierror many, one above threshold",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errConflict,
 				tsdb.ErrNotReady,
@@ -133,7 +133,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "matching multierror many, both above threshold, conflict have precedence",
-			err: errutil.MultiError([]error{
+			err: errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errConflict,
 				tsdb.ErrNotReady,
@@ -147,7 +147,7 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "nested matching multierror",
-			err: errors.Wrap(errors.Wrap(errutil.MultiError([]error{
+			err: errors.Wrap(errors.Wrap(errutil.NonNilMultiError([]error{
 				storage.ErrOutOfOrderSample,
 				errors.New("foo"),
 				errors.New("bar"),
@@ -157,8 +157,8 @@ func TestDetermineWriteErrorCause(t *testing.T) {
 		},
 		{
 			name: "deep nested matching multierror",
-			err: errors.Wrap(errutil.MultiError([]error{
-				errutil.MultiError([]error{
+			err: errors.Wrap(errutil.NonNilMultiError([]error{
+				errutil.NonNilMultiError([]error{
 					errors.New("qux"),
 					status.Error(codes.AlreadyExists, "conflict"),
 					status.Error(codes.AlreadyExists, "conflict"),