Addressed review comments

Signed-off-by: Marco Pracucci <[email protected]>
thanos-io · Jul 8, 2020 · 745d1de · 745d1de
1 parent c65bf8f
commit 745d1de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/docs/components/store.md b/docs/components/store.md
@@ -93,11 +93,14 @@ Flags:
                                  memory.
       --store.grpc.series-sample-limit=0
                                  Maximum amount of samples returned via a single
-                                 Series call. 0 means no limit. NOTE: For
-                                 efficiency we take 120 as the number of samples
-                                 in chunk (it cannot be bigger than that), so
-                                 the actual number of samples might be lower,
-                                 even though the maximum could be hit.
+                                 Series call. The Series call fails if this
+                                 limit is exceeded. 0 means no limit. NOTE: For
+                                 efficiency the limit is internally implemented
+                                 as 'chunks limit' considering each chunk
+                                 contains 120 samples (it's the max number of
+                                 samples each chunk can contain), so the actual
+                                 number of samples might be lower, even though
+                                 the maximum could be hit.
       --store.grpc.series-max-concurrency=20
                                  Maximum number of concurrent Series calls.
       --objstore.config-file=<file-path>

diff --git a/pkg/store/limiter.go b/pkg/store/limiter.go
@@ -28,8 +28,8 @@ type Limiter struct {
 	reserved uint64
 
 	// Counter metric which we will increase if limit is exceeded.
-	failedOnce    sync.Once
 	failedCounter prometheus.Counter
+	failedOnce    sync.Once
 }
 
 // NewLimiter returns a new limiter with a specified limit. 0 disables the limit.