Skip to content

Commit

Permalink
Store command flag parsing and run args refactoring (#4061)
Browse files Browse the repository at this point in the history
* Refactored store cmd

Adds `storeConfig` struct which contains all necessary params for store component.
Registers flags to this config and replaces all params in runStore with
single conf struct

Signed-off-by: someshkoli <[email protected]>

* adds missing prom/common/model package

Signed-off-by: someshkoli <[email protected]>

* removes duplicate min-time flag

Signed-off-by: someshkoli <[email protected]>

* Updates docs and fixes failing e2e test

- Updated docs
- fixes typo -> `app` to `cmd` which caused duplicate flag declaration
- changed indexCacheSizeBytes type from uint64 to model.bytes
- replaced maxconcurrent with max concurrency

Signed-off-by: someshkoli <[email protected]>

* changed chunkpoolsize and indexcachesuzebytes from to bytes

Signed-off-by: someshkoli <[email protected]>

* fixes nil store component passing

Signed-off-by: someshkoli <[email protected]>

* fixes improper cachebytes variable type

Signed-off-by: someshkoli <[email protected]>

* Adds register flag func for all flags

Signed-off-by: someshkoli <[email protected]>

* Update cmd/thanos/store.go

fix str formatting on min/max time

Co-authored-by: Kemal Akkoyun <[email protected]>
Signed-off-by: someshkoli <[email protected]>

* renames grpclogging import

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: someshkoli <[email protected]>

* renames commonmodel import

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: someshkoli <[email protected]>

* updates grpclogging and commommodel imports

Signed-off-by: someshkoli <[email protected]>

Co-authored-by: Kemal Akkoyun <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
  • Loading branch information
3 people authored Apr 21, 2021
1 parent f5174e0 commit 6d4d1c5
Showing 1 changed file with 137 additions and 147 deletions.
Loading

0 comments on commit 6d4d1c5

Please sign in to comment.