Skip to content

Commit

Permalink
blog: Fix images for LFX post (#6422)
Browse files Browse the repository at this point in the history
* blog: Fix images for LFX post

Signed-off-by: Saswata Mukherjee <[email protected]>

* fix lint

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>
  • Loading branch information
saswatamcode authored Jun 7, 2023
1 parent a114b9e commit 1788584
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions docs/blog/2023-06-02-lfx-mentorship-query-observability.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ Thanos needs to specify which engine to utilize to execute the promql queries. A

Here is the sketch of how the engine switch should look (made by Giedrius):

![Giedrius's Sketch](img/giedrius-sketch.png)
<img src="img/giedrius-sketch.png" alt="Giedrius&#39;s Sketch" width="800"/>

I looked into Thanos and made changes in Thanos components from the API to the UI to implement this engine switch. I tried to make the UI as close as possible to the sketch.

![Engine Switch 1](img/engine-1.png)
<img src="img/engine-1.png" alt="Engine Switch 1" width="800"/>

After initial review, I move this switch to each panel. As this helps to run the same query over the different engines and compare the results.

![Engine Switch 2](img/engine-2.png)
<img src="img/engine-2.png" alt="Engine Switch 2" width="800"/>

**Pull Requests**
- Add engine param to Thanos engine constructor ([thanos-io/promql-engine#228](https://github.com/thanos-io/promql-engine/pull/228))
Expand All @@ -56,11 +56,11 @@ I started with generating query explanations through the Thanos promql-engine an

Thanos UI got updated with time, resulting in the development of the explanation tree that can be seen through the screenshots provided.

![Tree 1](img/tree-1.png)
<img src="img/tree-1.png" alt="Tree 1" width="800"/>

![Tree 2](img/tree-2.png)
<img src="img/tree-2.png" alt="Tree 2" width="800"/>

![Tree 3](img/tree-3.png)
<img src="img/tree-3.png" alt="Tree 3" width="800"/>

**Pull Requests**
- Add method to explain query vector ([thanos-io/promql-engine#252](https://github.com/thanos-io/promql-engine/pull/252))
Expand Down

0 comments on commit 1788584

Please sign in to comment.