receive/multitsdb: remove double lock (#7700)

Do not double lock here as in some situations it could lead to a dead-lock situation. Signed-off-by: Giedrius Statkevičius <[email protected]>
thanos-io · Sep 5, 2024 · 0966192 · 0966192
1 parent 8c8a88e
commit 0966192
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/pkg/receive/multitsdb.go b/pkg/receive/multitsdb.go
@@ -266,17 +266,11 @@ func (t *tenant) readyStorage() *ReadyStorage {
 	return t.readyS
 }
 
-func (t *tenant) store() *store.TSDBStore {
-	t.mtx.RLock()
-	defer t.mtx.RUnlock()
-	return t.storeTSDB
-}
-
 func (t *tenant) client() store.Client {
 	t.mtx.RLock()
 	defer t.mtx.RUnlock()
 
-	tsdbStore := t.store()
+	tsdbStore := t.storeTSDB
 	if tsdbStore == nil {
 		return nil
 	}