bucket: handle instances where no blocks are loaded

Signed-off-by: Jacob Colvin <[email protected]>
thanos-io · Mar 17, 2020 · 090d99f · 090d99f
1 parent 081d749
commit 090d99f
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 71 deletions.
diff --git a/cmd/thanos/bucket.go b/cmd/thanos/bucket.go
@@ -464,14 +464,16 @@ func refresh(ctx context.Context, logger log.Logger, bucketUI *ui.Bucket, durati
 	})
 }
 
-func download(ctx context.Context, logger log.Logger, bkt objstore.Bucket, fetcher *block.MetaFetcher) (blocks []metadata.Meta, err error) {
+func download(ctx context.Context, logger log.Logger, bkt objstore.Bucket, fetcher *block.MetaFetcher) ([]metadata.Meta, error) {
 	level.Info(logger).Log("msg", "synchronizing block metadata")
 
 	metas, _, err := fetcher.Fetch(ctx)
 	if err != nil {
 		return nil, err
 	}
 
+	blocks := []metadata.Meta{}
+
 	for _, meta := range metas {
 		blocks = append(blocks, *meta)
 	}