Fixing problem on FilteredSelector when applying filter in series without filtered labels #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout filtered labels Signed-off-by: Pedro Tanaka <[email protected]> Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]> Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]> Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]> Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
fpetkovski
reviewed
Jan 28, 2023
execution/storage/filter.go
Outdated
| label := series.Labels().Get(name) | ||
| if !m.Matches(label) { | ||
| hasMatch = false | ||
| break |
There was a problem hiding this comment.
Maybe we can return false immediately here.
Signed-off-by: Pedro Tanaka <[email protected]>
GiedriusS
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a problem where a label matcher would match a series if the label did not exist in the series.
So, for example:
Would not match the selector
{foo~=".*"}, where it should to be compatible with Prometheus.See this added test case for more details.