All missing liveness and readiness probes #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
force-pushed
the
all_other_probes
branch
2 times, most recently
from
25974cf
to
915665c
Compare
|
@metalmatze All the dependent PRs are merged, we're good to go with this. |
|
Not sure I want to introduce |
|
@metalmatze Good idea, let's wait |
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
all_other_probes
branch
from
affa28b
to
181a708
Compare
Signed-off-by: Kemal Akkoyun <[email protected]>
|
@metalmatze The stable version of Thanos released https://github.com/thanos-io/thanos/releases/tag/v0.8.0 🎉 We're good to go with this one! |
metalmatze
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
This is waiting for upstream Thanos changes to be merged, thanos-io/thanos#1534, thanos-io/thanos#1460, thanos-io/thanos#1537, thanos-io/thanos#1538 and thanos-io/thanos#1540.