Make cache types case insensitive #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the case in thanos itself (https://github.com/thanos-io/thanos/blob/master/pkg/queryfrontend/config.go#L81 and https://github.com/thanos-io/thanos/blob/master/pkg/store/cache/factory.go#L45). The thanos docs use upper-case cache types. Signed-off-by: Craig Furman <[email protected]>
craigfurman
force-pushed
the
case-insensitive-caches
branch
from
0b349b9 to
11ed801
Compare
kakkoyun
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make cache types case insensitive
This appears to be the case in thanos itself
(https://github.com/thanos-io/thanos/blob/master/pkg/queryfrontend/config.go#L81
and https://github.com/thanos-io/thanos/blob/master/pkg/store/cache/factory.go#L45).
The thanos docs use upper-case cache types.
Previously, using an upper-case string "MEMCACHED" for memcached caches would work fine, except that the user would not inherit the kube-thanos defaults for memcached configs.
Verification
I ran
make generate validate, and have tried pulling in this branch to a development environment to validate that it works.