3.2.0 - Add volume & stop #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more information to methods and fix typos in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2.0 adds support for the following:
volumeandonVolumepropsstop()method andonStoppropWaiting on howler.js update
The latest published version of howler.js (2.0.0) includes a bug (goldfire/howler.js#595) that prevents
stop()from working correctly when the audio is paused. This bug has been fixed in the howler.js master branch but not published on npm. I'd like to wait to publish 3.2.0 until this bug is fixed upstream.If anyone needs these features before then, let me know and I can publish early with the caveat that stopping while paused will not work.