Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLID. Liskov Substitution Principle (LSP). Example incorrect. #96

Open
VitaliyPavlyukov opened this issue Dec 23, 2020 · 1 comment
Open

SOLID. Liskov Substitution Principle (LSP). Example incorrect. #96

VitaliyPavlyukov opened this issue Dec 23, 2020 · 1 comment

Comments

@VitaliyPavlyukov
Copy link

VitaliyPavlyukov commented Dec 23, 2020 •
edited
Loading

Drawable RenderLargeRectangles(Rectangle rectangles)
{
foreach (rectangle in rectangles)
{

rectangles must be array, not Rectangle
@dmitryvhf
Copy link

You are correct. Can you create PR with this changes?

azubrytski-dev added a commit to azubrytski-dev/clean-code-dotnet that referenced this issue Oct 25, 2022
@azubrytski-dev
Fixed thangchung#96: LSP Rectangles must be array
ca50293
azubrytski-dev added a commit to azubrytski-dev/clean-code-dotnet that referenced this issue Oct 25, 2022
@azubrytski-dev
Fixed thangchung#96: LSP Rectangles must be array
53c70f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VitaliyPavlyukov @dmitryvhf