Fixes flakey tests (opensearch-project#105)

* Fixes flakey cypress test 'rollup enable and disable test' * Fixes flakey unit test 'can delete a rollup job' Signed-off-by: Robert Downs <[email protected]>
thalurur · Oct 7, 2021 · 614cd5f · 614cd5f
1 parent 04d5d44
commit 614cd5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/cypress/integration/rollups_spec.js b/cypress/integration/rollups_spec.js
@@ -236,6 +236,9 @@ describe("Rollups", () => {
 
       cy.contains(`${ROLLUP_ID}`);
 
+      // Disable button is enabled
+      cy.get(`[data-test-subj="disableButton"]`).should("not.be.disabled");
+
       // Click Disable button
       cy.get(`[data-test-subj="disableButton"]`).trigger("click", { force: true });
 

diff --git a/public/pages/RollupDetails/containers/RollupDetails/RollupDetails.test.tsx b/public/pages/RollupDetails/containers/RollupDetails/RollupDetails.test.tsx
@@ -183,7 +183,9 @@ describe("<RollupDetails /> spec", () => {
     browserServicesMock.rollupService.deleteRollup = jest.fn().mockResolvedValue({ ok: true, response: true });
     const { getByTestId } = renderRollupDetailsWithRouter([`${ROUTES.ROLLUP_DETAILS}?id=${testRollup._id}`]);
 
-    await waitFor(() => {});
+    await waitFor(() => {
+      getByTestId("deleteButton");
+    });
 
     userEvent.click(getByTestId("deleteButton"));